Conversation
need to test csv
We now treat CSV output the same as JSON and YAML. A --fileoutput-dynamic flag was added to support the previous behavior for users who desire it
arikalon1
approved these changes
Jun 15, 2024
Contributor
arikalon1
left a comment
arikalon1
left a comment
There was a problem hiding this comment.
nice work
left one minor comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've had a number of bug reports over email about the csv export which doesn't respect
--fileoutput.This PR fixes that by changing the csv export so it respects
--fileoutput. For any users who prefer the old behavior, I've added a--fileoutput-dynamicflag that they can use to keep the previous behavior.Other Changes
I've also renamed the csv export so it is consistent with other exporter names. I've removed redundant code and made a tiny improvement to the table output in response to a common source of confusion w/ users.
Testing
I tested this PR manually by checking all the new flags and by checking behavior without any flags to verify that everything works as expected.